]> dgit.raspbian.org Git - gnome-shell.git/commit
keyboard: Hide keyboardBox after destroying the keyboard
authorJonas Dreßler <verdre@v0yd.nl>
Sat, 28 Mar 2020 13:36:20 +0000 (14:36 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Sat, 28 Mar 2020 20:45:32 +0000 (20:45 +0000)
commit867587ef4cb92a2f42580de8ec508198d43f4044
treecf7db45c6869eb7be0b56e404791b325f352a1a0
parentb68fb3578318fa4b50e7fa79d544d53f8b4f74c9
keyboard: Hide keyboardBox after destroying the keyboard

It seems there is a weird race condition between Clutter trying to
destroy the keyboard actor and Clutter trying to hide the keyboardBox
container actor: If the keyboardBox is hidden before destroying the
keyboard actor, Clutter doesn't repaint anything and the keyboard
remains visible until something else draws over it.

To fix this issue until we find the underlying Clutter bug, simply
destroy the keyboard actor before hiding the keyboardBox. The order in
which we call these doesn't matter anyway since hideKeyboard(true) hides
the keyboard immediately without an animation.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/1736
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1142
js/ui/keyboard.js